Skip to content

whisper.wasm : fix unknown language issue #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

danbev
Copy link
Collaborator

@danbev danbev commented Apr 3, 2025

This commit addresses an issue with whisper.wasm where the following error was being displayed when running the application in github pages:

whisper_lang_id: unknown language 'д=␙c'

This turned out to be a memory corruption issue and further details can be found in the reference issue below.

Refs: #2998


I've deployed this to: https://danbev.github.io/whisper.cpp/

This commit addresses an issue with whisper.wasm where the following
error was being displayed when running the application in github pages:
```
whisper_lang_id: unknown language 'д=␙c'
```

This turned out to be a memory corruption issue and further details
can be found in the reference issue below.

Refs: ggml-org#2998
Make sure that we always free the language pointer for multilingual
models.
@danbev
Copy link
Collaborator Author

danbev commented Apr 3, 2025

Something seems to be wrong with the freebsd job, it failed with an rsync error the first time and it appears to be "stalled" on terminating the VM when re-run. Perhaps this was a reason that is used to be disabled?

@danbev danbev merged commit 77e0c86 into ggml-org:master Apr 3, 2025
146 of 148 checks passed
@danbev danbev deleted the wasm-lang-issue branch April 24, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants